New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two queue cache under cache framework and change write statistics to two queue cache. #741

Merged
merged 6 commits into from Sep 14, 2017

Conversation

Projects
None yet
5 participants
@blacktear23
Contributor

blacktear23 commented Sep 7, 2017

  • Add two queue cache support
  • Change writeStatistic to TwoQueue cache

As ARC cache may cause patent issue so Two-Queue cache maybe another choice.

@sre-bot

This comment has been minimized.

Show comment
Hide comment
@sre-bot

sre-bot Sep 7, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

sre-bot commented Sep 7, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@nolouch

Thanks for your PR, now we do some research in hot spot schedule, if you have any interesting, you can also help us to do it.

Show outdated Hide outdated server/cache.go
return &TwoQueue{
size: size,
recentSize: recentSize,
recent: newLRU(size),

This comment has been minimized.

@disksing

disksing Sep 8, 2017

Member

size -> recentSize?

@disksing

disksing Sep 8, 2017

Member

size -> recentSize?

This comment has been minimized.

@blacktear23

blacktear23 Sep 8, 2017

Contributor

It should be size, because recent list should store size number item before Get hit and move item to frequent list.

@blacktear23

blacktear23 Sep 8, 2017

Contributor

It should be size, because recent list should store size number item before Get hit and move item to frequent list.

blacktear23 and others added some commits Sep 13, 2017

yulai.li
Show outdated Hide outdated server/cache.go
@@ -0,0 +1,163 @@
// Copyright 2017 PingCAP, Inc.

This comment has been minimized.

@siddontang

siddontang Sep 13, 2017

Member

em, I think we must include golang-lru license in this file.

@siddontang

siddontang Sep 13, 2017

Member

em, I think we must include golang-lru license in this file.

This comment has been minimized.

@blacktear23

blacktear23 Sep 13, 2017

Contributor

How to do that? just include golang-lru/LICENSE content? No header comment for 2q.go.

@blacktear23

blacktear23 Sep 13, 2017

Contributor

How to do that? just include golang-lru/LICENSE content? No header comment for 2q.go.

This comment has been minimized.

@siddontang

siddontang Sep 13, 2017

Member

yes, include golang-lru license

@siddontang

siddontang Sep 13, 2017

Member

yes, include golang-lru license

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Sep 13, 2017

Member

LGTM.

Member

disksing commented Sep 13, 2017

LGTM.

yulai.li and others added some commits Sep 13, 2017

@blacktear23

This comment has been minimized.

Show comment
Hide comment
@blacktear23

blacktear23 Sep 13, 2017

Contributor

Can anyone restart the test? seems some problem on travis-ci.

Contributor

blacktear23 commented Sep 13, 2017

Can anyone restart the test? seems some problem on travis-ci.

@nolouch

This comment has been minimized.

Show comment
Hide comment
@nolouch

nolouch Sep 13, 2017

Member

/run-full-test

Member

nolouch commented Sep 13, 2017

/run-full-test

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 13, 2017

Member

@nolouch please fix the CI

Member

siddontang commented Sep 13, 2017

@nolouch please fix the CI

@siddontang

Rest LGTM

@disksing disksing changed the title from [DNM] Add two queue cache under cache framework and change write statistics to two queue cache. to Add two queue cache under cache framework and change write statistics to two queue cache. Sep 14, 2017

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Sep 14, 2017

Member

/run-full-test

Member

disksing commented Sep 14, 2017

/run-full-test

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Sep 14, 2017

Member

/build

Member

disksing commented Sep 14, 2017

/build

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Sep 14, 2017

Member

/run-full-test

Member

disksing commented Sep 14, 2017

/run-full-test

@disksing disksing merged commit 63a7cdf into pingcap:master Sep 14, 2017

7 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
jenkins-ci-pd/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-pd/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-pd/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment