New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix active region statistic #744

Merged
merged 1 commit into from Sep 11, 2017

Conversation

Projects
None yet
4 participants
@nolouch
Member

nolouch commented Sep 11, 2017

if we lose some region stored in etcd, and restart PD. we will receive amount heartbeat to insert region, but we don't see it as an active region. then the scheduler will not run.

@nolouch nolouch requested review from siddontang, huachaohuang and disksing Sep 11, 2017

@siddontang

LGTM

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Sep 11, 2017

Member

/run-full-test

Member

disksing commented Sep 11, 2017

/run-full-test

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Sep 11, 2017

Member

LGTM.

Member

disksing commented Sep 11, 2017

LGTM.

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Sep 11, 2017

Member

/run-all-test tikv=pre-ga

Member

disksing commented Sep 11, 2017

/run-all-test tikv=pre-ga

@iamxy

This comment has been minimized.

Show comment
Hide comment
@iamxy

iamxy Sep 11, 2017

Member

/run-all-test tikv=pre-ga

Member

iamxy commented Sep 11, 2017

/run-all-test tikv=pre-ga

@nolouch nolouch merged commit e1b5faa into master Sep 11, 2017

8 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
jenkins-ci-pd/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-pd/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-pd/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@nolouch nolouch deleted the shuning/fix-schedule-start branch Sep 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment