New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namespace: add Classifier interface. #745

Merged
merged 3 commits into from Sep 13, 2017

Conversation

Projects
None yet
4 participants
@disksing
Member

disksing commented Sep 11, 2017

@nolouch

LGTM

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing
Member

disksing commented Sep 12, 2017

// DefaultClassifer is a classifier that classifies all regions and stores to
// DefaultNamespace.
var DefaultClassifer = defaultClassifer{}

This comment has been minimized.

@overvenus

overvenus Sep 12, 2017

Member

I think we need a mutex for protecting the DefaultClassifer, since we allow users to override it. And need to export an API to do so

@overvenus

overvenus Sep 12, 2017

Member

I think we need a mutex for protecting the DefaultClassifer, since we allow users to override it. And need to export an API to do so

This comment has been minimized.

@disksing

disksing Sep 12, 2017

Member

We won't allow users to change it as @siddontang suggested. The var is due to grammatical limitations.

@disksing

disksing Sep 12, 2017

Member

We won't allow users to change it as @siddontang suggested. The var is due to grammatical limitations.

@siddontang

LGTM

@disksing disksing merged commit 651d0dd into namespace Sep 13, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the disksing/classifier branch Sep 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment