New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule/operator: fix operator marshal and test #746

Merged
merged 3 commits into from Sep 12, 2017

Conversation

Projects
None yet
5 participants
@nolouch
Member

nolouch commented Sep 12, 2017

we need to show operator in API with the marshal function.

@nolouch nolouch requested review from siddontang, huachaohuang and disksing Sep 12, 2017

@huachaohuang

This comment has been minimized.

Show comment
Hide comment
@huachaohuang
Member

huachaohuang commented Sep 12, 2017

LGTM

@zhangjinpeng1987 zhangjinpeng1987 merged commit bf76b3f into master Sep 12, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zhangjinpeng1987 zhangjinpeng1987 deleted the shuning/fix-operator branch Sep 12, 2017

return fmt.Sprintf("%s (kind:%s, region:%v, createAt:%s, currentStep:%v, steps:%v)", o.desc, o.kind, o.regionID, o.createTime, atomic.LoadInt32(&o.currentStep), o.steps)
s := fmt.Sprintf("%s (kind:%s, region:%v, createAt:%s, currentStep:%v, steps:%+v) ", o.desc, o.kind, o.regionID, o.createTime, atomic.LoadInt32(&o.currentStep), o.steps)
if o.IsTimeout() {
s = s + "timeout"

This comment has been minimized.

@siddontang

siddontang Sep 13, 2017

Member

no blank before timeout here? I guess your output string will look ugly here, like "timeoutfinished".

@siddontang

siddontang Sep 13, 2017

Member

no blank before timeout here? I guess your output string will look ugly here, like "timeoutfinished".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment