New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/logutil: wrap InitLogger in sync.Once for thread-safety #753

Merged
merged 2 commits into from Sep 15, 2017

Conversation

Projects
None yet
3 participants
@tiancaiamao
Contributor

tiancaiamao commented Sep 14, 2017

TiDB call InitLogger parallel multiple times in the test code, lead to data race problem.

@andelf @disksing

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 14, 2017

Member

CI failed

Member

siddontang commented Sep 14, 2017

CI failed

@disksing

LGTM

@disksing disksing merged commit 8a08c6e into master Sep 15, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the tiancaiamao/log-init-once branch Sep 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment