New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: fix a bug that may set not empty store to tombstone state. #758

Merged
merged 2 commits into from Sep 18, 2017

Conversation

Projects
None yet
5 participants
@disksing
Member

disksing commented Sep 18, 2017

I reproduce the problem in the following steps:

  1. start 1pd+1tikv, wait for bootstrap.
  2. stop tikv and restart pd.
  3. use pd-ctl to remove store1.
  4. wait 1 minute, the store is tombstone state.

@disksing disksing requested review from siddontang, nolouch and huachaohuang Sep 18, 2017

Show outdated Hide outdated server/cluster.go
@nolouch

LGTM

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang
Member

siddontang commented Sep 18, 2017

@huachaohuang

This comment has been minimized.

Show comment
Hide comment
@huachaohuang
Member

huachaohuang commented Sep 18, 2017

LGTM

@disksing disksing merged commit f1f3bcb into master Sep 18, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the disksing/check-store branch Sep 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment