New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: merge hot region schedulers #765

Merged
merged 3 commits into from Sep 22, 2017

Conversation

Projects
None yet
5 participants
@nolouch
Member

nolouch commented Sep 20, 2017

merge hot write region and hot read region scheduler

@nolouch nolouch requested review from disksing and zhangjinpeng1987 Sep 20, 2017

@nolouch nolouch requested a review from siddontang Sep 20, 2017

@ngaut

This comment has been minimized.

Show comment
Hide comment
@ngaut

ngaut Sep 20, 2017

Member

Could you share performance details?

Member

ngaut commented Sep 20, 2017

Could you share performance details?

)
func init() {
schedule.RegisterScheduler("hotRegion", func(opt schedule.Options, args []string) (schedule.Scheduler, error) {

This comment has been minimized.

@siddontang

siddontang Sep 21, 2017

Member

I think we should change all name to kebab-case later.

/cc @disksing

@siddontang

siddontang Sep 21, 2017

Member

I think we should change all name to kebab-case later.

/cc @disksing

This comment has been minimized.

@disksing

disksing Sep 21, 2017

Member

@Connor1996 will take care of it.

@disksing

disksing Sep 21, 2017

Member

@Connor1996 will take care of it.

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 21, 2017

Member

This PR just removes duplicated code for read and write hot schedulers. No performance gain.

Member

siddontang commented Sep 21, 2017

This PR just removes duplicated code for read and write hot schedulers. No performance gain.

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang
Member

siddontang commented Sep 21, 2017

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Sep 22, 2017

Member

LGTM.

Member

disksing commented Sep 22, 2017

LGTM.

@siddontang siddontang merged commit 2ffe57f into master Sep 22, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@siddontang siddontang deleted the shuning/merge-scheduler branch Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment