New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new GetRegionNamespace #766

Merged
merged 4 commits into from Sep 22, 2017

Conversation

Projects
None yet
4 participants
@LiangShang
Collaborator

LiangShang commented Sep 21, 2017

No description provided.

@sre-bot

This comment has been minimized.

Show comment
Hide comment
@sre-bot

sre-bot Sep 21, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

sre-bot commented Sep 21, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Sep 22, 2017

Member

LGTM. But please fix CI.

Member

disksing commented Sep 22, 2017

LGTM. But please fix CI.

@nolouch

This comment has been minimized.

Show comment
Hide comment
@nolouch

nolouch Sep 22, 2017

Member

LGTM. please make dev and pass the check

Member

nolouch commented Sep 22, 2017

LGTM. please make dev and pass the check

@LiangShang LiangShang merged commit 1ae6402 into dantin/namespace Sep 22, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the liang/classifier branch Oct 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment