New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: clusterInfo refactor #767

Merged
merged 4 commits into from Sep 23, 2017

Conversation

Projects
None yet
5 participants
@qqsun8819
Collaborator

qqsun8819 commented Sep 23, 2017

This pr is a preparation for MockCluster.
1 move storesInfo, regionsInfo and regionTree into core package, and export their methods as public so that other modules like MockCluster can also use them.
2 move region_tree_test.go into core, and split some util test functions from this file into core/test_util.go, so that test suite like cache_test.go in server can use them.
3 move RegionMapTestSuite from cache_test.go into core/region_test.go for specific test of regionsMap.

scheduler: clusterInfo refactor
move storesInfo, regionsInfo and regionTree into core

@qqsun8819 qqsun8819 requested review from siddontang, nolouch and disksing Sep 23, 2017

@sre-bot

This comment has been minimized.

Show comment
Hide comment
@sre-bot

sre-bot Sep 23, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

sre-bot commented Sep 23, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

qqsun8819 added some commits Sep 23, 2017

@ngaut

This comment has been minimized.

Show comment
Hide comment
@ngaut

ngaut Sep 23, 2017

Member

Well done, @qqsun8819
PTAL

Member

ngaut commented Sep 23, 2017

Well done, @qqsun8819
PTAL

@siddontang

LGTM

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Sep 23, 2017

Member

LGTM.

Member

disksing commented Sep 23, 2017

LGTM.

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Sep 23, 2017

Member

/run-full-test

Member

disksing commented Sep 23, 2017

/run-full-test

@disksing disksing merged commit d3e7452 into master Sep 23, 2017

7 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
jenkins-ci-pd/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-pd/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-pd/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the qqsun8819/mockcluster branch Sep 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment