New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: refactor kv. #771

Merged
merged 2 commits into from Sep 27, 2017

Conversation

Projects
None yet
3 participants
@disksing
Member

disksing commented Sep 27, 2017

Extract kv to an interface. The benefits include a) plugin schedulers or namespace classifiers can save data without depend on server package, b) some tests can use in-memory storage without starting etcd server.

@disksing disksing requested review from qqsun8819, nolouch and Connor1996 Sep 27, 2017

}
// NewMemoryKV returns an in-memory kvBase for testing.
func NewMemoryKV() KVBase {

This comment has been minimized.

@siddontang

siddontang Sep 27, 2017

Member

any test to test the KV too?

@siddontang

siddontang Sep 27, 2017

Member

any test to test the KV too?

This comment has been minimized.

@disksing

disksing Sep 27, 2017

Member

Next PR will use it.

@disksing

disksing Sep 27, 2017

Member

Next PR will use it.

@nolouch

This comment has been minimized.

Show comment
Hide comment
@nolouch

nolouch Sep 27, 2017

Member

LGTM

Member

nolouch commented Sep 27, 2017

LGTM

@siddontang

LGTM

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Sep 27, 2017

Member

/run-all-test

Member

disksing commented Sep 27, 2017

/run-all-test

@disksing disksing merged commit a2c8a0b into master Sep 27, 2017

7 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
jenkins-ci-pd/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-pd/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-pd/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the disksing/kv branch Sep 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment