New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support removing table_id/store_id from namespace. #776

Merged
merged 10 commits into from Oct 9, 2017

Conversation

Projects
None yet
5 participants
@dantin
Collaborator

dantin commented Sep 28, 2017

  1. add info log
  2. add function to remove table_id/store_id from namespace
@sre-bot

This comment has been minimized.

Show comment
Hide comment
@sre-bot

sre-bot Sep 28, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

sre-bot commented Sep 28, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@dantin dantin requested a review from disksing Sep 28, 2017

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Sep 29, 2017

Member

/ok-to-test

Member

disksing commented Sep 29, 2017

/ok-to-test

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang
Member

siddontang commented Oct 9, 2017

PTAL @disksing

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Oct 9, 2017

Member

LGTM

Member

siddontang commented Oct 9, 2017

LGTM

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Oct 9, 2017

Member

LGTM.

Member

disksing commented Oct 9, 2017

LGTM.

@disksing disksing merged commit a2b6653 into namespace Oct 9, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the dantin/add_remove_namespace_command branch Oct 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment