New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: adjust region heartbeat metrics. #779

Merged
merged 3 commits into from Sep 29, 2017

Conversation

Projects
None yet
3 participants
@disksing
Member

disksing commented Sep 29, 2017

  1. Record store id.
  2. Increase counter after receive message.

@disksing disksing requested review from siddontang, nolouch and Connor1996 Sep 29, 2017

Show outdated Hide outdated server/grpc_service.go Outdated

disksing added some commits Sep 29, 2017

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang
Member

siddontang commented Sep 29, 2017

LGTM

PTAL @huachaohuang

@nolouch

LGTM

@disksing disksing merged commit 91e4257 into master Sep 29, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the disksing/heartbeat-metrics branch Sep 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment