New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core, api: store labels case-insensitive #794

Merged
merged 4 commits into from Oct 13, 2017

Conversation

Projects
None yet
4 participants
@Connor1996
Member

Connor1996 commented Oct 12, 2017

case-insensitive when comparing StoreLabel.key, the string store in StoreLabel is still case-sensitive

@disksing

LGTM

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang
Member

siddontang commented Oct 13, 2017

@huachaohuang

LGTM

@huachaohuang

This comment has been minimized.

Show comment
Hide comment
@huachaohuang

huachaohuang Oct 13, 2017

Member

/run-integration-tests

Member

huachaohuang commented Oct 13, 2017

/run-integration-tests

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Oct 13, 2017

Member

/run-integration-tests

Member

disksing commented Oct 13, 2017

/run-integration-tests

@siddontang siddontang merged commit 0297761 into master Oct 13, 2017

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
jenkins-ci-pd/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-pd/integration-ddl-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@siddontang siddontang deleted the connor/store-labels-case-insensitive branch Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment