New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api, pdctl: support add/remove region peer. #795

Merged
merged 4 commits into from Oct 13, 2017

Conversation

Projects
None yet
3 participants
@disksing
Member

disksing commented Oct 12, 2017

Fix #786.

@disksing disksing requested review from siddontang and Connor1996 Oct 12, 2017

step := schedule.AddPeer{ToStore: toStoreID, PeerID: newPeer.GetId()}
op := schedule.NewOperator("adminAddPeer", regionID, core.AdminKind, step)
c.addOperator(op)

This comment has been minimized.

@siddontang

siddontang Oct 12, 2017

Member

can we add another addPeer operator if the previous one has not been finished?

@siddontang

siddontang Oct 12, 2017

Member

can we add another addPeer operator if the previous one has not been finished?

This comment has been minimized.

@disksing

disksing Oct 12, 2017

Member

If old operator's type is not admin, the old one will be replaced.

@disksing

disksing Oct 12, 2017

Member

If old operator's type is not admin, the old one will be replaced.

@siddontang

LGTM

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang
Member

siddontang commented Oct 13, 2017

@nolouch

LGTM

@disksing disksing merged commit 50f0ae2 into master Oct 13, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the disksing/operator branch Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment