New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: adjust scheduler interface #798

Merged
merged 9 commits into from Oct 16, 2017

Conversation

Projects
None yet
4 participants
@nolouch
Member

nolouch commented Oct 14, 2017

this PR do:

  • let the scheduler control schedule interval by itself
  • let the scheduler know limiter and decide it can be scheduled. our scheduler may product two type operator, leader or peer, the controller does not distinguish them.

@nolouch nolouch requested review from siddontang, disksing and Connor1996 Oct 14, 2017

nolouch added some commits Oct 14, 2017

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Oct 14, 2017

Member

LGTM.

Member

disksing commented Oct 14, 2017

LGTM.

@Connor1996

This comment has been minimized.

Show comment
Hide comment
@Connor1996

Connor1996 Oct 16, 2017

Member

LGTM.

Member

Connor1996 commented Oct 16, 2017

LGTM.

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Oct 16, 2017

Member

We are going to merge it after GA.

Member

disksing commented Oct 16, 2017

We are going to merge it after GA.

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Oct 16, 2017

Member

/run-all-tests

Member

disksing commented Oct 16, 2017

/run-all-tests

@disksing disksing merged commit e10b9a2 into master Oct 16, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the shuning/adjust-scheduler branch Oct 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment