New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: filter store with lots of pending peers #811

Merged
merged 5 commits into from Oct 25, 2017

Conversation

Projects
None yet
3 participants
@nolouch
Member

nolouch commented Oct 23, 2017

we need filter the store with lots of pending peers when scheduling regions.

@nolouch nolouch requested review from siddontang, disksing and Connor1996 Oct 23, 2017

Show outdated Hide outdated server/cache.go Outdated
@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Oct 24, 2017

Member

Rest LGTM

Member

siddontang commented Oct 24, 2017

Rest LGTM

Show outdated Hide outdated server/cache.go Outdated
Show outdated Hide outdated server/core/region.go Outdated
@@ -305,7 +305,8 @@ func (c *Config) configFromFile(path string) error {
type ScheduleConfig struct {
// If the snapshot count of one store is greater than this value,
// it will never be used as a source or target store.
MaxSnapshotCount uint64 `toml:"max-snapshot-count,omitempty" json:"max-snapshot-count"`
MaxSnapshotCount uint64 `toml:"max-snapshot-count,omitempty" json:"max-snapshot-count"`
MaxPendingPeerCount uint64 `toml:"max-pending-peer-count,omitempty" json:"max-pending-peer-count"`

This comment has been minimized.

@disksing

disksing Oct 24, 2017

Member

Need to add it to config file?

@disksing

disksing Oct 24, 2017

Member

Need to add it to config file?

Show outdated Hide outdated server/cache_test.go Outdated
@disksing

The rest LGTM.

Show outdated Hide outdated server/schedule/filters.go Outdated

nolouch added some commits Oct 24, 2017

@disksing

LGTM

@siddontang siddontang merged commit bfaca3c into pingcap:master Oct 25, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment