New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coordinator: remove verbose kv #815

Merged
merged 2 commits into from Oct 26, 2017

Conversation

Projects
None yet
3 participants
@Connor1996
Member

Connor1996 commented Oct 25, 2017

we can get kv from clusterInfo in coordinator, so coordinator doesn't need kv field.

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Oct 26, 2017

Member

LGTM.

Member

disksing commented Oct 26, 2017

LGTM.

@huachaohuang

Rest LGTM.

Show outdated Hide outdated server/coordinator_test.go
Show outdated Hide outdated server/coordinator_test.go
Show outdated Hide outdated server/coordinator_test.go
Show outdated Hide outdated server/coordinator_test.go
@huachaohuang

This comment has been minimized.

Show comment
Hide comment
@huachaohuang

huachaohuang Oct 26, 2017

Member

/run-all-test

Member

huachaohuang commented Oct 26, 2017

/run-all-test

@Connor1996 Connor1996 merged commit 838f93c into pingcap:master Oct 26, 2017

8 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
jenkins-ci-pd/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-pd/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-pd/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-pd/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@Connor1996 Connor1996 deleted the Connor1996:connor/remove-verbose-kv branch Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment