New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table: adjust table id calculation. #823

Merged
merged 4 commits into from Oct 29, 2017

Conversation

Projects
None yet
3 participants
@disksing
Member

disksing commented Oct 27, 2017

In order to allow tikv to support region merge easily, now only split at the begining of a region.

ref pingcap/tidb#4926

@disksing disksing added this to the 1.1 milestone Oct 27, 2017

@@ -144,7 +144,7 @@ func (c *tableNamespaceClassifier) GetRegionNamespace(regionInfo *core.RegionInf
c.RLock()
defer c.RUnlock()
tableID := c.getTableID(regionInfo)
tableID := c.tableIDDecoder.DecodeTableID(regionInfo.StartKey)

This comment has been minimized.

@siddontang

siddontang Oct 27, 2017

Member

@disksing

Do we need to set metadata region to the special namespace later?

@siddontang

siddontang Oct 27, 2017

Member

@disksing

Do we need to set metadata region to the special namespace later?

This comment has been minimized.

@disksing

disksing Oct 27, 2017

Member

Good idea.

@disksing

disksing Oct 27, 2017

Member

Good idea.

This comment has been minimized.

@siddontang

siddontang Oct 27, 2017

Member

File an issue? @disksing

@siddontang

siddontang Oct 27, 2017

Member

File an issue? @disksing

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Oct 27, 2017

Member

LGTM

Member

siddontang commented Oct 27, 2017

LGTM

@nolouch

LGTM

@nolouch nolouch merged commit ee7aa64 into pingcap:master Oct 29, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the disksing:table-split branch Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment