New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: remove pending peer before add new peer. #826

Merged
merged 2 commits into from Oct 31, 2017

Conversation

Projects
None yet
3 participants
@disksing
Member

disksing commented Oct 31, 2017

Consider we have 3 peers (A, B, C), we set the store that contains C to offline while C is pending. If we generate an operator that adds a replica D then removes C, D will not be successfully added util C is normal again.

So it's better to remove C directly.

@disksing disksing requested review from siddontang and nolouch Oct 31, 2017

@nolouch

This comment has been minimized.

Show comment
Hide comment
@nolouch

nolouch Oct 31, 2017

Member

LGTM

Member

nolouch commented Oct 31, 2017

LGTM

@siddontang

LGTM

@disksing disksing merged commit 0defd4e into pingcap:master Oct 31, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the disksing:remove-pending branch Oct 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment