New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coordinator: clear hot store related gauges when store is not hot any more #833

Merged
merged 1 commit into from Nov 5, 2017

Conversation

Projects
None yet
5 participants
@foxmailed
Contributor

foxmailed commented Nov 3, 2017

2017-11-03 12 55 21

Above is a snapshot from one of our clusters

@sre-bot

This comment has been minimized.

Show comment
Hide comment
@sre-bot

sre-bot Nov 3, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

sre-bot commented Nov 3, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Nov 3, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Nov 3, 2017

CLA assistant check
All committers have signed the CLA.

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang
Member

siddontang commented Nov 3, 2017

LGTM

PTAL @disksing @nolouch

@nolouch

nolouch approved these changes Nov 5, 2017

LGTM

@nolouch nolouch merged commit ac44202 into pingcap:master Nov 5, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@foxmailed foxmailed deleted the foxmailed:clear_prev_hot_region_gauge branch Nov 6, 2017

disksing added a commit to disksing/pd that referenced this pull request Nov 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment