Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update drainer config #745

Merged
merged 3 commits into from Apr 30, 2019

Conversation

Projects
None yet
5 participants
@liubo0127
Copy link
Contributor

commented Apr 28, 2019

@WangXiangUSTC

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

LGTM

Show resolved Hide resolved conf/drainer-cluster.toml Outdated
Show resolved Hide resolved conf/drainer-cluster.toml Outdated
Show resolved Hide resolved conf/drainer-cluster.toml Outdated
Show resolved Hide resolved conf/drainer-cluster.toml Outdated
Show resolved Hide resolved conf/drainer-cluster.toml Outdated
Apply suggestions from code review
Co-Authored-By: liubo0127 <liubo@pingcap.com>
@CLAassistant

This comment has been minimized.

Copy link

commented Apr 28, 2019

CLA assistant check
All committers have signed the CLA.

@superlzs0476
Copy link
Contributor

left a comment

LGTM

@liubo0127 liubo0127 merged commit c4ea46d into pingcap:master Apr 30, 2019

1 check passed

license/cla Contributor License Agreement is signed.
Details

@liubo0127 liubo0127 deleted the liubo0127:liubo/update-drainer-conf branch Apr 30, 2019

liubo0127 added a commit that referenced this pull request Apr 30, 2019

Update drainer config (#745)
* Update drainer config

* Add new configuration items to binlog

* Apply suggestions from code review

Co-Authored-By: liubo0127 <liubo@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.