Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reparo/:Add worker-count, txn-batch config (#742) #746

Merged

Conversation

@lichunzhu
Copy link
Collaborator

commented Sep 9, 2019

What problem does this PR solve?

cherry-pick #742
TOOL-1547
Add worker count and txn batch config for reparo. Users can decide these indecies themselves to change the sync speed of reparo.

What is changed and how it works?

Expose worker count and txn batch to config.

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to update the documentation
  • Need to be included in the release note
@lichunzhu

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 9, 2019

/run-all-tests

@lichunzhu lichunzhu changed the title add new config for worker count and txn batch in both toml files and … reparo/:Add worker-count, txn-batch config (#742) Sep 9, 2019
@lichunzhu lichunzhu requested review from WangXiangUSTC and july2993 Sep 9, 2019
Copy link
Collaborator

left a comment

LGTM

@july2993 july2993 added status/LGT1 and removed status/PTAL labels Sep 9, 2019
Copy link
Member

left a comment

LGTM

@lichunzhu lichunzhu merged commit 9763c33 into pingcap:release-2.1 Sep 9, 2019
5 checks passed
5 checks passed
idc-jenkins-ci-binlog/build Jenkins job succeeded.
Details
idc-jenkins-ci-binlog/check Jenkins job succeeded.
Details
idc-jenkins-ci-tidb-binlog/integration-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb-binlog/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@lichunzhu lichunzhu deleted the lichunzhu:czli/release2.1/reparo/addWorkerTxn branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.