Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add switch for cluster client tls mounting #3282

Merged
merged 1 commit into from Sep 18, 2020

Conversation

DanielZhangQD
Copy link
Contributor

@DanielZhangQD DanielZhangQD commented Sep 18, 2020

What problem does this PR solve?

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
    • Set mountClusterClientSecret for PD and TiKV and cluster client TLS secret can be mounted to the container

Code changes

  • Has Go code change

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Add `mountClusterClientSecret` for PD and TiKV, if set it to `true`, TiDB Operator will mount the `${cluster_name}-cluster-client-secret` to the PD or TiKV containers

@codecov-commenter
Copy link

Codecov Report

Merging #3282 into master will decrease coverage by 0.93%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3282      +/-   ##
==========================================
- Coverage   40.71%   39.78%   -0.94%     
==========================================
  Files         172      172              
  Lines       19188    17558    -1630     
==========================================
- Hits         7812     6985     -827     
+ Misses      10714     9923     -791     
+ Partials      662      650      -12     
Flag Coverage Δ
#unittest 39.78% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@lichunzhu lichunzhu added the status/PTAL PR needs to be reviewed label Sep 18, 2020
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD DanielZhangQD merged commit f700c00 into pingcap:master Sep 18, 2020
@DanielZhangQD DanielZhangQD deleted the client0 branch September 18, 2020 04:27
ti-srebot pushed a commit to ti-srebot/tidb-operator that referenced this pull request Sep 18, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 in PR #3283

DanielZhangQD added a commit that referenced this pull request Sep 18, 2020
* cherry pick #3282 to release-1.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* fix conflict

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Co-authored-by: DanielZhangQD <zhanghailong810@aliyun.com>
cvvz pushed a commit to cvvz/tidb-operator that referenced this pull request Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants