From 44830b917465c5d46cd22f617a3e260f09f0b857 Mon Sep 17 00:00:00 2001 From: wjHuang Date: Wed, 19 May 2021 00:25:40 +0800 Subject: [PATCH] session: fix dml_batch_size doesn't load the global variable (#24710) --- session/session.go | 1 + session/session_test.go | 10 ++++++++++ 2 files changed, 11 insertions(+) diff --git a/session/session.go b/session/session.go index 78a60a6ebaecf..efd6706c4ffb3 100644 --- a/session/session.go +++ b/session/session.go @@ -2652,6 +2652,7 @@ var builtinGlobalVariable = []string{ variable.TiDBAllowFallbackToTiKV, variable.TiDBEnableDynamicPrivileges, variable.CTEMaxRecursionDepth, + variable.TiDBDMLBatchSize, } // loadCommonGlobalVariablesIfNeeded loads and applies commonly used global variables for the session. diff --git a/session/session_test.go b/session/session_test.go index f7267e3a13259..df2a167921e56 100644 --- a/session/session_test.go +++ b/session/session_test.go @@ -4476,3 +4476,13 @@ func (s *testTxnStateSuite) TestRollbacking(c *C) { c.Assert(tk.Se.TxnInfo().State, Equals, txninfo.TxnRollingBack) <-ch } + +func (s *testSessionSuite) TestReadDMLBatchSize(c *C) { + tk := testkit.NewTestKit(c, s.store) + tk.MustExec("set global tidb_dml_batch_size=1000") + se, err := session.CreateSession(s.store) + c.Assert(err, IsNil) + // `select 1` to load the global variables. + _, _ = se.Execute(context.TODO(), "select 1") + c.Assert(se.GetSessionVars().DMLBatchSize, Equals, 1000) +}