From 4fae2bfc12398c6e873b79f684287e49ba8309c5 Mon Sep 17 00:00:00 2001 From: xufei Date: Tue, 27 Sep 2022 08:25:20 +0800 Subject: [PATCH] address comments Signed-off-by: xufei --- expression/builtin_arithmetic.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/expression/builtin_arithmetic.go b/expression/builtin_arithmetic.go index dc161fb754723..b21b9dc6a5914 100644 --- a/expression/builtin_arithmetic.go +++ b/expression/builtin_arithmetic.go @@ -117,13 +117,11 @@ func setFlenDecimal4RealOrDecimal(ctx sessionctx.Context, retTp *types.FieldType retTp.SetFlen(types.UnspecifiedLength) return } - digitsInt := mathutil.Max(a.GetFlen()-a.GetDecimal(), b.GetFlen()-b.GetDecimal()) - if isMultiply { - digitsInt = a.GetFlen() - a.GetDecimal() + b.GetFlen() - b.GetDecimal() - } if isMultiply { + digitsInt := a.GetFlen() - a.GetDecimal() + b.GetFlen() - b.GetDecimal() retTp.SetFlenUnderLimit(digitsInt + retTp.GetDecimal()) } else { + digitsInt := mathutil.Max(a.GetFlen()-a.GetDecimal(), b.GetFlen()-b.GetDecimal()) retTp.SetFlenUnderLimit(digitsInt + retTp.GetDecimal() + 1) } if isReal {