From fb9d2203b991b95b1dcf5b1b25cf77fab80be276 Mon Sep 17 00:00:00 2001
From: Yiding Cui <winoros@gmail.com>
Date: Mon, 18 Dec 2023 16:40:53 +0800
Subject: [PATCH] expression: enum/set could be invalid during evaluation
 (#49543)

close pingcap/tidb#49487
---
 pkg/expression/chunk_executor.go                  | 15 ++++++++++++---
 .../integrationtest/r/expression/enum_set.result  | 13 +++++++++++++
 tests/integrationtest/t/expression/enum_set.test  | 12 ++++++++++++
 3 files changed, 37 insertions(+), 3 deletions(-)
 create mode 100644 tests/integrationtest/r/expression/enum_set.result
 create mode 100644 tests/integrationtest/t/expression/enum_set.test

diff --git a/pkg/expression/chunk_executor.go b/pkg/expression/chunk_executor.go
index 0e8d4243fa5c0..d675b0aa5d7e5 100644
--- a/pkg/expression/chunk_executor.go
+++ b/pkg/expression/chunk_executor.go
@@ -15,11 +15,12 @@
 package expression
 
 import (
-	"github.com/pingcap/errors"
 	"github.com/pingcap/tidb/pkg/parser/ast"
 	"github.com/pingcap/tidb/pkg/parser/mysql"
 	"github.com/pingcap/tidb/pkg/types"
 	"github.com/pingcap/tidb/pkg/util/chunk"
+	"github.com/pingcap/tidb/pkg/util/logutil"
+	"go.uber.org/zap"
 )
 
 // Vectorizable checks whether a list of expressions can employ vectorized execution.
@@ -181,7 +182,11 @@ func evalOneVec(ctx EvalContext, expr Expression, input *chunk.Chunk, output *ch
 				} else {
 					enum, err := types.ParseEnumName(ft.GetElems(), result.GetString(i), ft.GetCollate())
 					if err != nil {
-						return errors.Errorf("Wrong enum value parsed during evaluation")
+						logutil.BgLogger().Debug("Wrong enum name parsed during evaluation",
+							zap.String("The name to be parsed in the ENUM", result.GetString(i)),
+							zap.Strings("The valid names in the ENUM", ft.GetElems()),
+							zap.Error(err),
+						)
 					}
 					buf.AppendEnum(enum)
 				}
@@ -197,7 +202,11 @@ func evalOneVec(ctx EvalContext, expr Expression, input *chunk.Chunk, output *ch
 				} else {
 					set, err := types.ParseSetName(ft.GetElems(), result.GetString(i), ft.GetCollate())
 					if err != nil {
-						return errors.Errorf("Wrong set value parsed during evaluation")
+						logutil.BgLogger().Debug("Wrong set name parsed during evaluation",
+							zap.String("The name to be parsed in the SET", result.GetString(i)),
+							zap.Strings("The valid names in the SET", ft.GetElems()),
+							zap.Error(err),
+						)
 					}
 					buf.AppendSet(set)
 				}
diff --git a/tests/integrationtest/r/expression/enum_set.result b/tests/integrationtest/r/expression/enum_set.result
new file mode 100644
index 0000000000000..1c40536bb1c2b
--- /dev/null
+++ b/tests/integrationtest/r/expression/enum_set.result
@@ -0,0 +1,13 @@
+drop table if exists t01;
+CREATE TABLE `t01` (
+`6524d87a` timestamp DEFAULT '2024-10-02 01:54:55',
+`744e4d52` int(11) NOT NULL DEFAULT '2023959529',
+`087de3b2` varchar(122) DEFAULT '36h0hvfpylz0f0iv9h0ownfcg3rehi4',
+`26cbbf2a` enum('l7i9','3sdz3','83','4','92p','4g','8y5rn','7gp','7','1','e') NOT NULL DEFAULT '4',
+PRIMARY KEY (`744e4d52`,`26cbbf2a`) /*T![clustered_index] CLUSTERED */
+) ENGINE=InnoDB DEFAULT CHARSET=gbk COLLATE=gbk_chinese_ci COMMENT='7ad99128'
+PARTITION BY HASH (`744e4d52`) PARTITIONS 9;
+insert ignore into t01 values ("2023-01-01 20:01:02", 123, 'abcd', '');
+select `t01`.`26cbbf2a` as r0 from `t01` where `t01`.`6524d87a` in ( '2010-05-25') or not( `t01`.`26cbbf2a` > '1' ) ;
+r0
+
diff --git a/tests/integrationtest/t/expression/enum_set.test b/tests/integrationtest/t/expression/enum_set.test
new file mode 100644
index 0000000000000..5bd90859381ec
--- /dev/null
+++ b/tests/integrationtest/t/expression/enum_set.test
@@ -0,0 +1,12 @@
+# https://github.com/pingcap/tidb/issues/49487
+drop table if exists t01;
+CREATE TABLE `t01` (
+  `6524d87a` timestamp DEFAULT '2024-10-02 01:54:55',
+  `744e4d52` int(11) NOT NULL DEFAULT '2023959529',
+  `087de3b2` varchar(122) DEFAULT '36h0hvfpylz0f0iv9h0ownfcg3rehi4',
+  `26cbbf2a` enum('l7i9','3sdz3','83','4','92p','4g','8y5rn','7gp','7','1','e') NOT NULL DEFAULT '4',
+  PRIMARY KEY (`744e4d52`,`26cbbf2a`) /*T![clustered_index] CLUSTERED */
+) ENGINE=InnoDB DEFAULT CHARSET=gbk COLLATE=gbk_chinese_ci COMMENT='7ad99128'
+PARTITION BY HASH (`744e4d52`) PARTITIONS 9;
+insert ignore into t01 values ("2023-01-01 20:01:02", 123, 'abcd', '');
+select `t01`.`26cbbf2a` as r0 from `t01` where `t01`.`6524d87a` in ( '2010-05-25') or not( `t01`.`26cbbf2a` > '1' ) ;
\ No newline at end of file