Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong config item description in config.toml.example #10816

Closed
qw4990 opened this issue Jun 14, 2019 · 1 comment
Closed

wrong config item description in config.toml.example #10816

qw4990 opened this issue Jun 14, 2019 · 1 comment
Labels
type/bug This issue is a bug.

Comments

@qw4990
Copy link
Contributor

qw4990 commented Jun 14, 2019

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.
    Description of max-memory is wrong.

  2. What did you expect to see?
    It may be Max memory size to use in plan cache.

  3. What did you see instead?
    Max memory size to use in plan cache, 0 use the total usable memory in the machine.

  4. What version of TiDB are you using (tidb-server -V or run select tidb_version(); on TiDB)?
    The latest master branch.

@ghost ghost added the type/bug This issue is a bug. label Jul 23, 2020
@github-actions github-actions bot added this to Need Triage in Question and Bug Reports Jul 23, 2020
@ghost ghost moved this from Need Triage to Closed(This Week) in Question and Bug Reports Jul 29, 2020
@ghost
Copy link

ghost commented Jul 29, 2020

This appears to be fixed in master:

nullnotnil@ubuntu:~/go/src/github.com/nullnotnil/tidb/config$ grep -RFi 'max-memory' config.toml.example 
nullnotnil@ubuntu:~/go/src/github.com/nullnotnil/tidb/config$ grep -RFi 'memory' config.toml.example 
# The maximum memory available for a single SQL statement. Default: 1GB
# Controls whether to enable the temporary storage for some operators when a single SQL statement exceeds the memory quota specified by mem-quota-query.
# Specifies the temporary storage path for some operators when a single SQL statement exceeds the memory quota specified by mem-quota-query.
# Specifies what operation TiDB performs when a single SQL statement exceeds the memory quota specified by mem-quota-query and cannot be spilled over to disk.
# Memory size quota for tidb server, 0 means unlimited
server-memory-quota = 0
# The max number of query feedback that cache in memory.
# the interval duration between two memory profile into global tracker
memory-guard-ratio = 0.1
# QueueSize controls how many spans the reporter can keep in memory before it starts dropping
# Whether to enable the copr cache. The copr cache saves the result from TiKV Coprocessor in the memory and
# max number of statements kept in memory.

I am going to go ahead and close this issue now. Please feel free to reopen if this is in error. Thanks!

@ghost ghost closed this as completed Jul 29, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug This issue is a bug.
Projects
No open projects
Question and Bug Reports
  
Closed(Archived Every Week)
Development

No branches or pull requests

1 participant