Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/kvencoder: add more unit test #10008

Merged
merged 7 commits into from Apr 8, 2019

Conversation

Projects
None yet
4 participants
@crazycs520
Copy link
Contributor

crazycs520 commented Apr 2, 2019

What problem does this PR solve?

add more unit test for util/kvencoder.

What is changed and how it works?

...
OK: 14 passed
PASS
coverage: 86.8% of statements
ok      github.com/pingcap/tidb/util/kvencoder  1.835s

Check List

Tests

  • No code
@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 3, 2019

/run-all-tests

1 similar comment
@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 3, 2019

/run-all-tests

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #10008 into master will increase coverage by 0.0341%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             master    #10008        +/-   ##
===============================================
+ Coverage   78.0088%   78.043%   +0.0341%     
===============================================
  Files           404       404                
  Lines         82024     82024                
===============================================
+ Hits          63986     64014        +28     
+ Misses        13332     13312        -20     
+ Partials       4706      4698         -8

crazycs520 and others added some commits Apr 4, 2019

@xiekeyi98

This comment has been minimized.

Copy link
Contributor

xiekeyi98 commented Apr 8, 2019

/run-integration-common-test tidb-test=pr/778

@xiekeyi98

This comment has been minimized.

Copy link
Contributor

xiekeyi98 commented Apr 8, 2019

/run-all-tests

@xiekeyi98
Copy link
Contributor

xiekeyi98 left a comment

LGTM.

@winkyao

winkyao approved these changes Apr 8, 2019

Copy link
Member

winkyao left a comment

LGTM

@crazycs520 crazycs520 merged commit bb23eac into pingcap:master Apr 8, 2019

8 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 7b688ee...6408086
Details
codecov/project 78.043% (+0.0341%) compared to 7b688ee
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/code_coverage Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.