Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: change db-table/{table_partition_id} http api #10026

Merged
merged 13 commits into from Apr 12, 2019

Conversation

Projects
None yet
4 participants
@crazycs520
Copy link
Contributor

crazycs520 commented Apr 3, 2019

What problem does this PR solve?

TiFlash maybe use tableID or paritionID to requst the http://{IP}:10090/db-table/{table_id} http api, if use partitionID, we should also return the partition table info.

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 3, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #10026 into master will increase coverage by 0.0002%.
The diff coverage is 75.862%.

@@               Coverage Diff                @@
##             master     #10026        +/-   ##
================================================
+ Coverage   78.0196%   78.0199%   +0.0002%     
================================================
  Files           405        405                
  Lines         82169      82138        -31     
================================================
- Hits          64108      64084        -24     
+ Misses        13352      13349         -3     
+ Partials       4709       4705         -4
Show resolved Hide resolved server/http_handler.go Outdated
Show resolved Hide resolved server/http_handler.go Outdated

crazycs520 added some commits Apr 4, 2019

@winkyao
Copy link
Member

winkyao left a comment

LGTM

@zimulala
Copy link
Member

zimulala left a comment

LGTM

@zimulala

This comment has been minimized.

Copy link
Member

zimulala commented Apr 9, 2019

/run-all-tests

@zimulala zimulala added the status/LGT2 label Apr 9, 2019

crazycs520 added some commits Apr 9, 2019

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 10, 2019

/run-all-tests

zz-jason and others added some commits Apr 11, 2019

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 11, 2019

/run-all-tests

5 similar comments
@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 11, 2019

/run-all-tests

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 11, 2019

/run-all-tests

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 11, 2019

/run-all-tests

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 11, 2019

/run-all-tests

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 11, 2019

/run-all-tests

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 12, 2019

/run-all-tests

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 12, 2019

/run-unit-test

@crazycs520 crazycs520 merged commit 3ad3b3d into pingcap:master Apr 12, 2019

14 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/code_coverage Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

crazycs520 added a commit to crazycs520/tidb that referenced this pull request Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.