Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, executor: support fast analyze in planner and executor's builder. #10040

Merged
merged 18 commits into from Apr 10, 2019

Conversation

Projects
None yet
4 participants
@lzmhhh123
Copy link
Member

lzmhhh123 commented Apr 4, 2019

What problem does this PR solve?

A sub PR for fast analyze. Reference: #9973
Pre-requirement PR: #10039

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported variable/fields change

Side effects

  • Increased code complexity

Related changes

  • none
ci

lzmhhh123 added some commits Apr 4, 2019

@lzmhhh123

This comment has been minimized.

Copy link
Member Author

lzmhhh123 commented Apr 4, 2019

PTAL @lamxTyler @zz-jason @erjiaqing , another unsubmitted PR "fast analyze execution" is blocked by this one.

Show resolved Hide resolved executor/analyze.go Outdated
Show resolved Hide resolved planner/core/planbuilder.go Outdated
Show resolved Hide resolved planner/core/common_plans.go
Show resolved Hide resolved planner/core/common_plans.go
Show resolved Hide resolved executor/builder.go
@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #10040 into master will decrease coverage by 0.0687%.
The diff coverage is 17.2131%.

@@               Coverage Diff                @@
##             master     #10040        +/-   ##
================================================
- Coverage   78.1141%   78.0454%   -0.0688%     
================================================
  Files           405        405                
  Lines         82044      82156       +112     
================================================
+ Hits          64088      64119        +31     
- Misses        13248      13331        +83     
+ Partials       4708       4706         -2

lzmhhh123 added some commits Apr 5, 2019

Show resolved Hide resolved executor/builder.go Outdated
Show resolved Hide resolved executor/builder.go Outdated
Show resolved Hide resolved store/mockstore/mocktikv/rpc.go Outdated
Show resolved Hide resolved planner/core/planbuilder.go Outdated
Show resolved Hide resolved executor/builder.go Outdated

@lzmhhh123 lzmhhh123 force-pushed the lzmhhh123:dev/fast_analyze_planner branch from 5969886 to afbbe21 Apr 9, 2019

lzmhhh123 added some commits Apr 9, 2019

fix
Show resolved Hide resolved executor/analyze.go
Show resolved Hide resolved executor/analyze.go Outdated
@lamxTyler
Copy link
Member

lamxTyler left a comment

LGTM

lzmhhh123 added some commits Apr 9, 2019

@lamxTyler lamxTyler requested a review from winoros Apr 10, 2019

@lzmhhh123

This comment has been minimized.

Copy link
Member Author

lzmhhh123 commented Apr 10, 2019

PTAL. @winoros

@winoros
Copy link
Member

winoros left a comment

lgtm

@lamxTyler

This comment has been minimized.

Copy link
Member

lamxTyler commented Apr 10, 2019

/run-all-tests

@zz-jason zz-jason merged commit 5b469e0 into pingcap:master Apr 10, 2019

16 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 17.2131% of diff hit (target 0%)
Details
codecov/project 78.0454% (-0.0688%) compared to f778a0c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/code_coverage Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.