Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planer: tiny refine code to return as early as possible In convertToIndexScan and convertToTableScan. #10058

Merged
merged 18 commits into from Apr 12, 2019

Conversation

Projects
None yet
4 participants
@crazycs520
Copy link
Contributor

crazycs520 commented Apr 6, 2019

What problem does this PR solve?

Not a problem, just to make the code to return as early as possible

What is changed and how it works?

Check List

Tests

  • No code: no code logic change

Code changes

Side effects

Related changes

@crazycs520 crazycs520 requested a review from eurekaka Apr 6, 2019

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 6, 2019

/run-all-tests

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 6, 2019

Codecov Report

Merging #10058 into master will decrease coverage by 0.0254%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10058        +/-   ##
================================================
- Coverage   78.0633%   78.0379%   -0.0254%     
================================================
  Files           405        405                
  Lines         82214      82210         -4     
================================================
- Hits          64179      64155        -24     
- Misses        13331      13345        +14     
- Partials       4704       4710         +6

@crazycs520 crazycs520 changed the title planer: tiny refine code to return as early as possible planer: tiny refine code to return as early as possible In convertToIndexScan and convertToTableScan. Apr 6, 2019

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Apr 6, 2019

@crazycs520 please fix ci

Show resolved Hide resolved planner/core/find_best_task.go Outdated
@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 8, 2019

/run-all-tests

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 8, 2019

/run-integration-common-test

1 similar comment
@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 8, 2019

/run-integration-common-test

crazycs520 added some commits Apr 8, 2019

is.addPushedDownSelection(cop, ds, expectedCnt, path)
// prop.IsEmpty() would always return true when coming to here,
// so we can just use prop.ExpectedCnt as parameter of addPushedDownSelection.
is.addPushedDownSelection(cop, ds, prop.ExpectedCnt, path)

This comment has been minimized.

Copy link
@eurekaka

eurekaka Apr 10, 2019

Contributor

We can further more extract addPushedDownSelection out of the if-else branch now?

This comment has been minimized.

Copy link
@crazycs520

crazycs520 Apr 10, 2019

Author Contributor

done.

@winoros
Copy link
Member

winoros left a comment

lgtm

@eurekaka
Copy link
Contributor

eurekaka left a comment

LGTM

@eurekaka

This comment has been minimized.

Copy link
Contributor

eurekaka commented Apr 10, 2019

/run-all-tests

1 similar comment
@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 10, 2019

/run-all-tests

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 10, 2019

/run-all-tests

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Apr 11, 2019

/run-all-tests

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 11, 2019

/run-all-tests

2 similar comments
@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 11, 2019

/run-all-tests

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 11, 2019

/run-all-tests

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 12, 2019

/run-all-tests

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Apr 12, 2019

/run-mybatis-test

@crazycs520 crazycs520 merged commit 175bae4 into pingcap:master Apr 12, 2019

8 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 0%)
Details
codecov/project Absolute coverage decreased by -0.0254% but relative coverage increased by +21.9366% compared to 3ad3b3d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/code_coverage Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.