Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta/autoid: remove the useless struct of memoryAllocator #10061

Merged
merged 5 commits into from Apr 9, 2019

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Apr 8, 2019

What problem does this PR solve?

Before this PR:
ok github.com/pingcap/tidb/meta/autoid 0.195s coverage: 79.7% of statements
After this PR:
ok github.com/pingcap/tidb/meta/autoid 0.138s coverage: 91.0% of statements

What is changed and how it works?

It seems that NewMemoryAllocator doesn't be used. So I remove it.

Check List

Tests

  • No code

@zimulala
Copy link
Contributor Author

zimulala commented Apr 8, 2019

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Apr 8, 2019

/rebuild

@zimulala
Copy link
Contributor Author

zimulala commented Apr 8, 2019

/run-common-test

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added component/parser status/LGT1 Indicates that a PR has LGTM 1. labels Apr 8, 2019
@zz-jason
Copy link
Member

zz-jason commented Apr 8, 2019

/run-all-tests

@zimulala
Copy link
Contributor Author

zimulala commented Apr 9, 2019

/run-unit-test

Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaut ngaut added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 9, 2019
@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@915b879). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #10061   +/-   ##
===========================================
  Coverage          ?   78.0764%           
===========================================
  Files             ?        404           
  Lines             ?      81944           
  Branches          ?          0           
===========================================
  Hits              ?      63979           
  Misses            ?      13275           
  Partials          ?       4690

@ngaut ngaut merged commit dd08a0a into pingcap:master Apr 9, 2019
@zimulala zimulala deleted the autoid-ut branch April 10, 2019 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants