New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta/autoid: remove the useless struct of memoryAllocator #10061
Conversation
/run-all-tests |
/rebuild |
/run-common-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/run-unit-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #10061 +/- ##
===========================================
Coverage ? 78.0764%
===========================================
Files ? 404
Lines ? 81944
Branches ? 0
===========================================
Hits ? 63979
Misses ? 13275
Partials ? 4690 |
What problem does this PR solve?
Before this PR:
ok github.com/pingcap/tidb/meta/autoid 0.195s coverage: 79.7% of statements
After this PR:
ok github.com/pingcap/tidb/meta/autoid 0.138s coverage: 91.0% of statements
What is changed and how it works?
It seems that
NewMemoryAllocator
doesn't be used. So I remove it.Check List
Tests