Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta/autoid: remove the useless struct of memoryAllocator #10061

Merged
merged 5 commits into from Apr 9, 2019

Conversation

Projects
None yet
4 participants
@zimulala
Copy link
Member

zimulala commented Apr 8, 2019

What problem does this PR solve?

Before this PR:
ok github.com/pingcap/tidb/meta/autoid 0.195s coverage: 79.7% of statements
After this PR:
ok github.com/pingcap/tidb/meta/autoid 0.138s coverage: 91.0% of statements

What is changed and how it works?

It seems that NewMemoryAllocator doesn't be used. So I remove it.

Check List

Tests

  • No code
@zimulala

This comment has been minimized.

Copy link
Member Author

zimulala commented Apr 8, 2019

/run-all-tests

@qw4990

This comment has been minimized.

Copy link
Contributor

qw4990 commented Apr 8, 2019

/rebuild

@zimulala

This comment has been minimized.

Copy link
Member Author

zimulala commented Apr 8, 2019

/run-common-test

@zz-jason
Copy link
Member

zz-jason left a comment

LGTM

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Apr 8, 2019

/run-all-tests

@zimulala

This comment has been minimized.

Copy link
Member Author

zimulala commented Apr 9, 2019

/run-unit-test

@ngaut

ngaut approved these changes Apr 9, 2019

Copy link
Member

ngaut left a comment

LGTM

@ngaut ngaut added status/LGT2 and removed status/LGT1 labels Apr 9, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 9, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@915b879). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #10061   +/-   ##
===========================================
  Coverage          ?   78.0764%           
===========================================
  Files             ?        404           
  Lines             ?      81944           
  Branches          ?          0           
===========================================
  Hits              ?      63979           
  Misses            ?      13275           
  Partials          ?       4690

@ngaut ngaut merged commit dd08a0a into pingcap:master Apr 9, 2019

4 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
idc-jenkins-ci-tidb/code_coverage Jenkins job is running.
Details
ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zimulala zimulala deleted the zimulala:autoid-ut branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.