Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: close RecordSet to avoid leak test failure #10063

Merged
merged 3 commits into from Apr 8, 2019

Conversation

Projects
None yet
4 participants
@eurekaka
Copy link
Contributor

eurekaka commented Apr 8, 2019

What problem does this PR solve?

Fix failure found in https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/2330/pipeline/

What is changed and how it works?

Use ExecToErr instead of Exec if we do not care about the result, since ExecToErr would close RecordSet.

Check List

Tests

  • No code

Code changes

N/A

Side effects

N/A

Related changes

N/A

@eurekaka

This comment has been minimized.

Copy link
Contributor Author

eurekaka commented Apr 8, 2019

/run-all-tests

@XuHuaiyu

This comment has been minimized.

Copy link
Contributor

XuHuaiyu commented Apr 8, 2019

/run-all-tests tidb-test=pr/781

@eurekaka eurekaka requested review from crazycs520 and zz-jason Apr 8, 2019

@zimulala
Copy link
Member

zimulala left a comment

LGTM

@eurekaka

This comment has been minimized.

Copy link
Contributor Author

eurekaka commented Apr 8, 2019

The common-test has finished successfully, but seems the status is not uploaded, so I think it is proper to add the label all tests passed.

@zz-jason
Copy link
Member

zz-jason left a comment

LGTM

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels Apr 8, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #10063 into master will increase coverage by 0.0378%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##            master     #10063        +/-   ##
===============================================
+ Coverage   78.033%   78.0708%   +0.0378%     
===============================================
  Files          404        404                
  Lines        81996      81996                
===============================================
+ Hits         63984      64015        +31     
+ Misses       13316      13294        -22     
+ Partials      4696       4687         -9

@zz-jason zz-jason merged commit 1e5f620 into pingcap:master Apr 8, 2019

8 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing b0f15ba...29f83f2
Details
codecov/project 77.9659% (-0.0671%) compared to b0f15ba
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/code_coverage Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@eurekaka eurekaka deleted the eurekaka:leak_fix branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.