Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: improve ut coverage to 100% #10066

Merged
merged 4 commits into from Apr 9, 2019

Conversation

Projects
None yet
4 participants
@bb7133
Copy link
Contributor

bb7133 commented Apr 8, 2019

What problem does this PR solve?

Simply add more unit tests for package metrics, improve ut coverage to 100%

What is changed and how it works?

Add UT

Check List

Tests

Unit test

Show resolved Hide resolved metrics/server_test.go Outdated
@zz-jason
Copy link
Member

zz-jason left a comment

LGTM

@zz-jason zz-jason added the status/LGT1 label Apr 8, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #10066 into master will decrease coverage by 0.0247%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #10066        +/-   ##
================================================
- Coverage   78.0444%   78.0196%   -0.0248%     
================================================
  Files           404        404                
  Lines         81970      81996        +26     
================================================
  Hits          63973      63973                
- Misses        13308      13322        +14     
- Partials       4689       4701        +12
@bb7133

This comment has been minimized.

Copy link
Contributor Author

bb7133 commented Apr 8, 2019

@zimulala @xiekeyi98 PTAL, thx!

@zimulala
Copy link
Member

zimulala left a comment

LGTM

@zimulala zimulala added status/LGT2 and removed status/LGT1 labels Apr 9, 2019

@zimulala

This comment has been minimized.

Copy link
Member

zimulala commented Apr 9, 2019

/run-all-tests

@xiekeyi98 xiekeyi98 merged commit f6a36e0 into pingcap:master Apr 9, 2019

16 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 1e5f620...acb2b01
Details
codecov/project 78.0196% (-0.0248%) compared to 1e5f620
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/code_coverage Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.