Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: move out some code from http_handler.go #10071

Merged
merged 3 commits into from Apr 9, 2019

Conversation

Projects
None yet
3 participants
@winoros
Copy link
Member

winoros commented Apr 8, 2019

What problem does this PR solve?

Move out some code out of the HTTP handler. So that it can be used if we construct a mem table stores the same thing.

What is changed and how it works?

Code movement and add new unit test.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

@winoros winoros requested review from crazycs520, lysu and lamxTyler Apr 9, 2019

@zz-jason
Copy link
Member

zz-jason left a comment

LGTM

@zz-jason zz-jason added the status/LGT1 label Apr 9, 2019

@lysu

lysu approved these changes Apr 9, 2019

Copy link
Member

lysu left a comment

LGTM

@lysu lysu added status/LGT2 and removed status/LGT1 labels Apr 9, 2019

@winoros winoros merged commit 7acbe52 into pingcap:master Apr 9, 2019

4 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
idc-jenkins-ci-tidb/code_coverage Jenkins job is running.
Details
ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@winoros winoros deleted the winoros:helper branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.