Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable: validate setting read_only variable #10072

Merged
merged 4 commits into from Apr 12, 2019

Conversation

Projects
None yet
5 participants
@jackysp
Copy link
Member

jackysp commented Apr 8, 2019

What problem does this PR solve?

set global read_only = abc;

then

select @@read_only;

will get abc, which does not make sense.

What is changed and how it works?

Fix it, only 1/0/on/off will be the valid values.

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change
@jackysp

This comment has been minimized.

Copy link
Member Author

jackysp commented Apr 9, 2019

/run-all-tests

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #10072 into master will increase coverage by 0.0255%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10072        +/-   ##
================================================
+ Coverage   77.9461%   77.9716%   +0.0255%     
================================================
  Files           405        405                
  Lines         82244      82244                
================================================
+ Hits          64106      64127        +21     
+ Misses        13404      13384        -20     
+ Partials       4734       4733         -1
@crazycs520
Copy link
Contributor

crazycs520 left a comment

LGTM

@lamxTyler
Copy link
Member

lamxTyler left a comment

LGTM

@lamxTyler

This comment has been minimized.

Copy link
Member

lamxTyler commented Apr 10, 2019

/run-common-test
/run-integration-common-test

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Apr 11, 2019

/run-common-test
/run-integration-common-test

jackysp added some commits Apr 8, 2019

@jackysp jackysp force-pushed the jackysp:read_only_var branch from 3cc4422 to f9ab09f Apr 12, 2019

@jackysp

This comment has been minimized.

Copy link
Member Author

jackysp commented Apr 12, 2019

/run-all-tests

@lysu

lysu approved these changes Apr 12, 2019

@jackysp jackysp merged commit b376139 into pingcap:master Apr 12, 2019

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/code_coverage Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.