Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
variable: validate setting read_only variable #10072
What problem does this PR solve?
What is changed and how it works?
Fix it, only 1/0/on/off will be the valid values.
@@ Coverage Diff @@ ## master #10072 +/- ## ================================================ + Coverage 77.9461% 77.9716% +0.0255% ================================================ Files 405 405 Lines 82244 82244 ================================================ + Hits 64106 64127 +21 + Misses 13404 13384 -20 + Partials 4734 4733 -1
Apr 12, 2019
6 checks passed
ci/circleci Your tests passed on CircleCI!Details
continuous-integration/travis-ci/pr The Travis CI build passedDetails
idc-jenkins-ci-tidb/build Jenkins job succeeded.Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.Details
idc-jenkins-ci-tidb/code_coverage Jenkins job succeeded.Details
license/cla Contributor License Agreement is signed.Details
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.