Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix json_key not compatible with MySQL #10090

Merged
merged 7 commits into from Apr 12, 2019

Conversation

Projects
None yet
5 participants
@b41sh
Copy link
Contributor

b41sh commented Apr 9, 2019

What problem does this PR solve?

Fix json_key not compatible with MySQL. #9989

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #10090 into master will decrease coverage by 0.0033%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10090        +/-   ##
================================================
- Coverage   77.9582%   77.9549%   -0.0034%     
================================================
  Files           405        405                
  Lines         82244      82218        -26     
================================================
- Hits          64116      64093        -23     
+ Misses        13398      13396         -2     
+ Partials       4730       4729         -1
@crazycs520
Copy link
Contributor

crazycs520 left a comment

LGTM. Thanks for the contribution.

@crazycs520

This comment has been minimized.

Copy link
Contributor

crazycs520 commented Apr 10, 2019

@XuHuaiyu PTAL

@zhouqiang-cl

This comment has been minimized.

Copy link
Member

zhouqiang-cl commented Apr 10, 2019

/rebuild

@b41sh

This comment has been minimized.

Copy link
Contributor Author

b41sh commented Apr 12, 2019

@xiekeyi98 PTAL

@bb7133 bb7133 added the status/LGT1 label Apr 12, 2019

@bb7133

bb7133 approved these changes Apr 12, 2019

Copy link
Contributor

bb7133 left a comment

LGTM

@bb7133

This comment has been minimized.

Copy link
Contributor

bb7133 commented Apr 12, 2019

Kindly remind, you can use 'close #9989' to automatically close issues in GitHub.

@bb7133 bb7133 added status/LGT2 and removed status/LGT1 labels Apr 12, 2019

@bb7133

This comment has been minimized.

Copy link
Contributor

bb7133 commented Apr 12, 2019

/run-all-tests

@bb7133 bb7133 merged commit 0a9569a into pingcap:master Apr 12, 2019

8 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 0%)
Details
codecov/project Absolute coverage decreased by -0.0033% but relative coverage increased by +22.0417% compared to 7447f04
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/code_coverage Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@b41sh

This comment has been minimized.

Copy link
Contributor Author

b41sh commented Apr 12, 2019

ok, thank you @bb7133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.