Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: extract month support 0 #10116

Merged
merged 3 commits into from Apr 11, 2019

Conversation

Projects
None yet
4 participants
@WangXiangUSTC
Copy link
Member

WangXiangUSTC commented Apr 11, 2019

What problem does this PR solve?

fix extract month in issue #9728
select extract(MONTH FROM "0000-00-00") should return 0

What is changed and how it works?

remove some code, and add unit test

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

@qw4990 qw4990 added the type/bug-fix label Apr 11, 2019

@qw4990 qw4990 self-requested a review Apr 11, 2019

@qw4990
Copy link
Contributor

qw4990 left a comment

LGTM

@qw4990 qw4990 requested a review from lamxTyler Apr 11, 2019

@lamxTyler
Copy link
Member

lamxTyler left a comment

LGTM

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 11, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@4f20b5b). Click here to learn what that means.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master     #10116   +/-   ##
===========================================
  Coverage          ?   78.6088%           
===========================================
  Files             ?        405           
  Lines             ?      83885           
  Branches          ?          0           
===========================================
  Hits              ?      65941           
  Misses            ?      13245           
  Partials          ?       4699
@lamxTyler

This comment has been minimized.

Copy link
Member

lamxTyler commented Apr 11, 2019

/run-all-tests

@qw4990 qw4990 referenced this pull request Apr 11, 2019

Open

Incompatible issues about date and time functions #9717

19 of 29 tasks complete
@qw4990

This comment has been minimized.

Copy link
Contributor

qw4990 commented Apr 11, 2019

/rebuild

@zz-jason zz-jason merged commit 7423c3c into pingcap:master Apr 11, 2019

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/code_coverage Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@WangXiangUSTC WangXiangUSTC deleted the WangXiangUSTC:xiang/fix_extract_month branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.