Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: add the transaction commit time to slow log #10294

Merged
merged 3 commits into from Apr 29, 2019

Conversation

Projects
None yet
4 participants
@jackysp
Copy link
Member

commented Apr 28, 2019

What problem does this PR solve?

The commit time and the statement execution time should be merged together in slow log.

What is changed and how it works?

Record the slow log in runStmt.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch
@jackysp

This comment has been minimized.

Copy link
Member Author

commented Apr 28, 2019

/run-all-tests

@jackysp jackysp requested review from crazycs520 and lysu Apr 28, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 28, 2019

Codecov Report

Merging #10294 into master will increase coverage by 0.0185%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10294        +/-   ##
================================================
+ Coverage   77.8219%   77.8404%   +0.0185%     
================================================
  Files           410        410                
  Lines         84728      84695        -33     
================================================
- Hits          65937      65927        -10     
+ Misses        13861      13845        -16     
+ Partials       4930       4923         -7
1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Apr 28, 2019

Codecov Report

Merging #10294 into master will increase coverage by 0.0185%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10294        +/-   ##
================================================
+ Coverage   77.8219%   77.8404%   +0.0185%     
================================================
  Files           410        410                
  Lines         84728      84695        -33     
================================================
- Hits          65937      65927        -10     
+ Misses        13861      13845        -16     
+ Partials       4930       4923         -7
@codecov

This comment has been minimized.

Copy link

commented Apr 28, 2019

Codecov Report

Merging #10294 into master will increase coverage by 0.0234%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10294        +/-   ##
================================================
+ Coverage   77.8087%   77.8322%   +0.0234%     
================================================
  Files           410        410                
  Lines         84966      84704       -262     
================================================
- Hits          66111      65927       -184     
+ Misses        13909      13854        -55     
+ Partials       4946       4923        -23
@coocood

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

LGTM

@crazycs520
Copy link
Contributor

left a comment

LGTM

@crazycs520
Copy link
Contributor

left a comment

@tiancaiamao

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

LGTM

@jackysp jackysp merged commit d814958 into pingcap:master Apr 29, 2019

5 of 6 checks passed

ci/circleci CircleCI is running your tests
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

jackysp added a commit to jackysp/tidb that referenced this pull request Apr 29, 2019

jackysp added a commit that referenced this pull request Apr 30, 2019

benpigchu added a commit to benpigchu/tidb that referenced this pull request May 7, 2019

@jackysp jackysp deleted the jackysp:refine_slow_log branch May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.