Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain: fix updating the self schema version and update log #10324

Merged
merged 4 commits into from May 6, 2019

Conversation

Projects
None yet
5 participants
@zimulala
Copy link
Member

commented Apr 30, 2019

What problem does this PR solve?

Updating the self-schema version to etcd is wrong when executing GetSnapshotInfoSchema.

What is changed and how it works?

If the neededSchemaVersion isn't the latest schema version.
Update the logs and rename ”latestSchemaVersion“ to ” neededSchemaVersion“

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch
@zimulala

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2019

/run-all-tests

@codecov

This comment has been minimized.

Copy link

commented Apr 30, 2019

Codecov Report

Merging #10324 into master will increase coverage by 0.0118%.
The diff coverage is 86.9565%.

@@               Coverage Diff                @@
##             master     #10324        +/-   ##
================================================
+ Coverage   77.6707%   77.6825%   +0.0118%     
================================================
  Files           411        411                
  Lines         85435      85413        -22     
================================================
- Hits          66358      66351         -7     
+ Misses        14112      14103         -9     
+ Partials       4965       4959         -6
@jackysp
Copy link
Member

left a comment

LGTM

@crazycs520
Copy link
Contributor

left a comment

LGTM

@shenli shenli added status/LGT2 and removed status/LGT1 labels May 5, 2019

@zimulala zimulala merged commit 303f3c9 into pingcap:master May 6, 2019

8 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 86.9565% of diff hit (target 0%)
Details
codecov/project 77.6825% (+0.0118%) compared to c9cc3b7
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zimulala zimulala deleted the zimulala:update-self-ver branch May 6, 2019

zimulala added a commit to zimulala/tidb that referenced this pull request May 6, 2019

benpigchu added a commit to benpigchu/tidb that referenced this pull request May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.