Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: addition between `datetime` and `interval` is not compatible with Mysql #10329

Merged
merged 21 commits into from May 10, 2019

Conversation

@erjiaqing
Copy link
Contributor

commented Apr 30, 2019

What problem does this PR solve?

Fix #9727

What is changed and how it works?

  • Changes in types/time.go is to extract day from duration to avoid overflow.

Check List

Tests

  • Unit test

erjiaqing added some commits Apr 30, 2019

fix
fix
@codecov

This comment has been minimized.

Copy link

commented Apr 30, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@5617809). Click here to learn what that means.
The diff coverage is 84.2105%.

@@             Coverage Diff             @@
##             master     #10329   +/-   ##
===========================================
  Coverage          ?   77.4068%           
===========================================
  Files             ?        412           
  Lines             ?      85902           
  Branches          ?          0           
===========================================
  Hits              ?      66494           
  Misses            ?      14347           
  Partials          ?       5061

@erjiaqing erjiaqing force-pushed the erjiaqing:issue_9727 branch from 933b90d to d22eca1 May 5, 2019

Show resolved Hide resolved types/time.go Outdated

@qw4990 qw4990 requested review from lamxTyler and winoros May 6, 2019

erjiaqing added some commits May 6, 2019

Show resolved Hide resolved expression/builtin_time.go Outdated
Show resolved Hide resolved types/time.go Outdated
Show resolved Hide resolved types/time.go
Show resolved Hide resolved types/time.go Outdated

erjiaqing added some commits May 7, 2019

fix
@qw4990
Copy link
Contributor

left a comment

LGTM

@qw4990 qw4990 requested review from lamxTyler and winoros May 9, 2019

Show resolved Hide resolved types/time.go

erjiaqing added some commits May 9, 2019

fix

@erjiaqing erjiaqing requested a review from lamxTyler May 9, 2019

@lamxTyler
Copy link
Member

left a comment

LGTM

@lamxTyler

This comment has been minimized.

Copy link
Member

commented May 10, 2019

/run-all-tests

fix
@erjiaqing

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

/run-all-tests

@zz-jason
Copy link
Member

left a comment

LGTM

@zz-jason zz-jason merged commit d241d74 into pingcap:master May 10, 2019

16 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 84.2105% of diff hit (target 0%)
Details
codecov/project No report found to compare against
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

erjiaqing added a commit to erjiaqing/tidb that referenced this pull request May 10, 2019

zz-jason added a commit that referenced this pull request May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.