Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: addition between `datetime` and real `interval` is not compatible with Mysql #10347

Merged
merged 1 commit into from May 9, 2019

Conversation

Projects
None yet
4 participants
@erjiaqing
Copy link
Contributor

commented May 5, 2019

What problem does this PR solve?

Fix #10346

What is changed and how it works?

Add builtin{Add|Sub}Date{Datetime|String|Int}RealSig to support float type intervals.

Check List

Tests

  • Integration test
@codecov

This comment has been minimized.

Copy link

commented May 5, 2019

Codecov Report

Merging #10347 into master will decrease coverage by 0.0379%.
The diff coverage is 51.1811%.

@@               Coverage Diff               @@
##             master     #10347       +/-   ##
===============================================
- Coverage   77.6755%   77.6375%   -0.038%     
===============================================
  Files           411        411               
  Lines         85440      85514       +74     
===============================================
+ Hits          66366      66391       +25     
- Misses        14113      14142       +29     
- Partials       4961       4981       +20
@codecov

This comment has been minimized.

Copy link

commented May 5, 2019

Codecov Report

Merging #10347 into master will decrease coverage by 0.045%.
The diff coverage is 51.1811%.

@@               Coverage Diff                @@
##             master     #10347        +/-   ##
================================================
- Coverage   77.3733%   77.3282%   -0.0451%     
================================================
  Files           412        412                
  Lines         85722      85847       +125     
================================================
+ Hits          66326      66384        +58     
- Misses        14370      14412        +42     
- Partials       5026       5051        +25

@qw4990 qw4990 referenced this pull request May 6, 2019

Open

Incompatible issues about date and time functions #9717

29 of 33 tasks complete

@qw4990 qw4990 added the type/bug-fix label May 8, 2019

@qw4990 qw4990 requested review from qw4990 and winoros May 8, 2019

@qw4990
Copy link
Contributor

left a comment

LGTM

@qw4990 qw4990 requested review from eurekaka, lamxTyler and winoros and removed request for winoros May 8, 2019

@lamxTyler
Copy link
Member

left a comment

LGTM

@lamxTyler

This comment has been minimized.

Copy link
Member

commented May 9, 2019

/run-all-tests

1 similar comment
@cwen0

This comment has been minimized.

Copy link
Member

commented May 9, 2019

/run-all-tests

@cwen0

This comment has been minimized.

Copy link
Member

commented May 9, 2019

/rebuild

1 similar comment
@qw4990

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

/rebuild

@erjiaqing erjiaqing force-pushed the erjiaqing:issue_10346 branch from 913c808 to 5002d4d May 9, 2019

@erjiaqing

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

/run-all-tests

@qw4990

qw4990 approved these changes May 9, 2019

@qw4990 qw4990 merged commit c2e83af into pingcap:master May 9, 2019

16 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 51.1811% of diff hit (target 0%)
Details
codecov/project 77.3282% (-0.0451%) compared to 37e8241
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@erjiaqing erjiaqing deleted the erjiaqing:issue_10346 branch May 9, 2019

erjiaqing added a commit to erjiaqing/tidb that referenced this pull request May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.