Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindinfo: reduce duplicate DigestHash call #10352

Merged
merged 4 commits into from May 6, 2019

Conversation

Projects
None yet
4 participants
@lysu
Copy link
Member

commented May 5, 2019

What problem does this PR solve?

fixes (3) of pingcap/parser#313, we can lex once when stmt isn't explain ...

this PR will also update parser version after pingcap/parser#313 be merged

What is changed and how it works?

use NormalizeDigest to generate normalize sql and hash at once

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • impl change

Side effects

  • N/A

Related changes

  • N/A

This change is Reviewable

@lysu lysu added the type/bug-fix label May 5, 2019

@lysu

This comment has been minimized.

Copy link
Member Author

commented May 5, 2019

/run-all-tests

@codecov

This comment has been minimized.

Copy link

commented May 5, 2019

Codecov Report

Merging #10352 into master will decrease coverage by 0.0126%.
The diff coverage is 86.6666%.

@@               Coverage Diff               @@
##             master    #10352        +/-   ##
===============================================
- Coverage   77.6687%   77.656%   -0.0127%     
===============================================
  Files           411       411                
  Lines         85463     85419        -44     
===============================================
- Hits          66378     66333        -45     
- Misses        14124     14125         +1     
  Partials       4961      4961

@lysu lysu force-pushed the lysu:avoid-infine-loop-invalid-token branch from bb30346 to 2167118 May 5, 2019

@lysu

This comment has been minimized.

Copy link
Member Author

commented May 5, 2019

/run-all-tests

@lysu lysu requested review from lamxTyler and jackysp May 6, 2019

@lamxTyler
Copy link
Member

left a comment

LGTM

@jackysp
Copy link
Member

left a comment

LGTM

@jackysp

This comment has been minimized.

Copy link
Member

commented May 6, 2019

/run-all-tests

@jackysp

jackysp approved these changes May 6, 2019

@jackysp jackysp added status/LGT2 and removed status/LGT1 labels May 6, 2019

@ngaut ngaut merged commit 190990b into pingcap:master May 6, 2019

8 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 86.6666% of diff hit (target 0%)
Details
codecov/project Absolute coverage decreased by -0.0126% but relative coverage increased by +8.9979% compared to 461512b
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

benpigchu added a commit to benpigchu/tidb that referenced this pull request May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.