Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table:modify 'desc' and 'show columns' statement is compatible with MySQL #10358

Merged
merged 4 commits into from May 8, 2019

Conversation

Projects
None yet
4 participants
@mantuliu
Copy link
Contributor

commented May 5, 2019

What problem does this PR solve?

the issue 10337

What is changed and how it works?

when we use statements such as desc, show columns, etc., the value of the returned column 'Extra' is determined by the method in column.go: NewColDesc.
after the codes commit,when the type of the column is timestamp and is set to update according to the current timestamp, the return value of the statement such as desc for extra: DEFAULT_GENERATED on update CURRENT_TIMESTAMP.

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

mantuliu added some commits May 5, 2019

@codecov

This comment has been minimized.

Copy link

commented May 5, 2019

Codecov Report

Merging #10358 into master will increase coverage by 0.0011%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##            master     #10358        +/-   ##
===============================================
+ Coverage   77.383%   77.3841%   +0.0011%     
===============================================
  Files          412        412                
  Lines        85573      85586        +13     
===============================================
+ Hits         66219      66230        +11     
- Misses       14334      14335         +1     
- Partials      5020       5021         +1

@morgo morgo self-requested a review May 5, 2019

@morgo
Copy link
Member

left a comment

LGTM

@ngaut

This comment has been minimized.

Copy link
Member

commented May 5, 2019

/run-all-tests

@lonng

lonng approved these changes May 7, 2019

Copy link
Member

left a comment

LGTM

@ngaut ngaut merged commit 1ef1d8a into pingcap:master May 8, 2019

8 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 77.3841% (+0.0011%) compared to a5f86a3
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@lonng

This comment has been minimized.

Copy link
Member

commented May 8, 2019

@mantuliu Please cherry-pick to release branch, many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.