Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: split unit tests to speedup execution time #10364

Merged
merged 3 commits into from May 6, 2019

Conversation

Projects
None yet
5 participants
@eurekaka
Copy link
Contributor

commented May 6, 2019

What problem does this PR solve?

Try to speedup unit test execution time.

What is changed and how it works?

Split tests in testSuite2 into 2 separate suites, and run them in parallel.

Check List

Tests

  • No code

Code changes

N/A

Side effects

N/A

Related changes

N/A

@eurekaka

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

/run-unit-test

2 similar comments
@eurekaka

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

/run-unit-test

@zhouqiang-cl

This comment has been minimized.

Copy link
Member

commented May 6, 2019

/run-unit-test

@eurekaka eurekaka marked this pull request as ready for review May 6, 2019

@eurekaka

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

/run-all-tests

@codecov

This comment has been minimized.

Copy link

commented May 6, 2019

Codecov Report

Merging #10364 into master will decrease coverage by 0.3277%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             master    #10364        +/-   ##
===============================================
- Coverage   77.6497%   77.322%   -0.3278%     
===============================================
  Files           412       411         -1     
  Lines         85547     85422       -125     
===============================================
- Hits          66427     66050       -377     
- Misses        14150     14362       +212     
- Partials       4970      5010        +40
@jackysp
Copy link
Member

left a comment

LGTM

@zimulala
Copy link
Member

left a comment

LGTM

@zimulala zimulala added the status/LGT2 label May 6, 2019

@ngaut ngaut merged commit f17a115 into pingcap:master May 6, 2019

5 of 6 checks passed

ci/circleci CircleCI is running your tests
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@eurekaka eurekaka deleted the eurekaka:executor_ut branch May 7, 2019

benpigchu added a commit to benpigchu/tidb that referenced this pull request May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.