Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: check if period is valid in `period_add` #10380

Merged
merged 6 commits into from May 9, 2019

Conversation

@qw4990
Copy link
Contributor

commented May 7, 2019

What problem does this PR solve?

fix #9736.

What is changed and how it works?

add validPeriod.

Check List

Tests

  • Unit test
@mantuliu

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

#10332 is the same question. @qw4990 @lonng

@qw4990

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

#10332 is the same question. @qw4990 @lonng

Yes, it seems that #10332 can be fixed by this PR.

@lamxTyler
Copy link
Member

left a comment

LGTM

@qw4990 qw4990 requested a review from lonng May 8, 2019

Show resolved Hide resolved expression/builtin_time.go
Show resolved Hide resolved expression/builtin_time.go
@codecov

This comment has been minimized.

Copy link

commented May 8, 2019

Codecov Report

Merging #10380 into master will increase coverage by 0.0008%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10380        +/-   ##
================================================
+ Coverage   77.3505%   77.3514%   +0.0008%     
================================================
  Files           412        412                
  Lines         85724      85692        -32     
================================================
- Hits          66308      66284        -24     
+ Misses        14387      14379         -8     
  Partials       5029       5029

@qw4990 qw4990 changed the title expression: fix issue that `period_add` is not compatible with MySQL expression: check if period is valid in `period_add` May 8, 2019

@qw4990

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

PTAL

@XuHuaiyu
Copy link
Contributor

left a comment

LGTM

@qw4990

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

/run-all-tests

@qw4990 qw4990 force-pushed the qw4990:fix-9736 branch from 4992d18 to 1fa56cf May 9, 2019

@qw4990

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

/run-all-tests

@qw4990 qw4990 added the status/LGT2 label May 9, 2019

@qw4990

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

To solve the CI problem, I git rebase this PR to master without any change, so please help me to approve this PR again~ @lamxTyler @XuHuaiyu

@qw4990 qw4990 merged commit 37e8241 into pingcap:master May 9, 2019

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@qw4990 qw4990 referenced this pull request May 9, 2019

Open

Incompatible issues about date and time functions #9717

29 of 33 tasks complete

qw4990 added a commit to qw4990/tidb that referenced this pull request May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.