Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: only retry needed regions when get region row count #10429

Merged
merged 5 commits into from May 21, 2019

Conversation

@lamxTyler
Copy link
Member

lamxTyler commented May 13, 2019

What problem does this PR solve?

Fast analyze will retry all the regions when one of the requests of getting region row count failed, in cases that there are many regions and updates, fast analyze would never succeed.

What is changed and how it works?

Only retry the needed region instead of all the regions.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • None
executor/analyze.go Outdated Show resolved Hide resolved
executor/analyze.go Show resolved Hide resolved
executor/analyze.go Show resolved Hide resolved
executor/analyze.go Outdated Show resolved Hide resolved
@codecov

This comment has been minimized.

Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #10429 into master will increase coverage by 0.0147%.
The diff coverage is 68.75%.

@@               Coverage Diff               @@
##             master    #10429        +/-   ##
===============================================
+ Coverage   77.2912%   77.306%   +0.0147%     
===============================================
  Files           413       413                
  Lines         87244     87217        -27     
===============================================
- Hits          67432     67424         -8     
+ Misses        14622     14606        -16     
+ Partials       5190      5187         -3
Copy link
Contributor

eurekaka left a comment

LGTM

executor/analyze.go Outdated Show resolved Hide resolved
Copy link
Contributor

qw4990 left a comment

LGTM

@qw4990

This comment has been minimized.

Copy link
Contributor

qw4990 commented May 21, 2019

/run-all-tests

lamxTyler added 2 commits May 21, 2019
@lamxTyler

This comment has been minimized.

Copy link
Member Author

lamxTyler commented May 21, 2019

/run-all-tests

@qw4990
qw4990 approved these changes May 21, 2019
Copy link
Contributor

qw4990 left a comment

LGTM

@qw4990 qw4990 merged commit 2fedfd0 into pingcap:master May 21, 2019
16 checks passed
16 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 68.75% of diff hit (target 0%)
Details
codecov/project 77.306% (+0.0147%) compared to f6346a1
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@lamxTyler lamxTyler deleted the lamxTyler:retry branch May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.