Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: add unit test for plugin #10506

Merged
merged 4 commits into from Jun 10, 2019

Conversation

Projects
None yet
4 participants
@lysu
Copy link
Member

commented May 16, 2019

What problem does this PR solve?

add unit test

What is changed and how it works?

add unit test

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • test

Side effects

  • N/A

Related changes

  • N/A

This change is Reviewable

@codecov

This comment has been minimized.

Copy link

commented May 16, 2019

Codecov Report

Merging #10506 into master will increase coverage by 0.1858%.
The diff coverage is 27.5862%.

@@               Coverage Diff               @@
##            master     #10506        +/-   ##
===============================================
+ Coverage   79.564%   79.7498%   +0.1858%     
===============================================
  Files          415        415                
  Lines        88266      88266                
===============================================
+ Hits         70228      70392       +164     
+ Misses       12841      12662       -179     
- Partials      5197       5212        +15

lysu added some commits May 15, 2019

@lysu lysu force-pushed the lysu:dev-improve-plugin-cover branch from f79ccb3 to 628de6e May 16, 2019

@mahjonp

This comment has been minimized.

Copy link

commented May 16, 2019

/rebuild

1 similar comment
@lysu

This comment has been minimized.

Copy link
Member Author

commented May 16, 2019

/rebuild

@lysu

This comment has been minimized.

Copy link
Member Author

commented May 20, 2019

/run-all-tests tidb-test=pr/822

@tiancaiamao

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

/run-unit-test

@tiancaiamao

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

LGTM

@lysu lysu requested a review from jackysp Jun 10, 2019

@jackysp
Copy link
Member

left a comment

LGTM

@jackysp jackysp merged commit 2ee59f1 into pingcap:master Jun 10, 2019

8 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 27.5862% of diff hit (target 0%)
Details
codecov/project 79.7498% (+0.1858%) compared to 59b5e1d
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

lysu added a commit to lysu/tidb that referenced this pull request Jul 10, 2019

lysu added a commit to lysu/tidb that referenced this pull request Jul 10, 2019

lysu added a commit to lysu/tidb that referenced this pull request Jul 11, 2019

ngaut added a commit that referenced this pull request Jul 15, 2019

plugin: support dynamic enable/disable plugins(#11122)(#10923)(#10506) (
#11189)

* plugin: add unit test for plugin (#10506)

* plugin: setup connection info in session when audit plugin be enabled (#10923)

*  plugin: support dynamic enable/disable plugins (#11122)

* update parser version & fix cp compile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.