Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
expression: fix Invalid JSONs #10510
@@ Coverage Diff @@ ## master #10510 +/- ## =========================================== Coverage ? 79.5716% =========================================== Files ? 415 Lines ? 88103 Branches ? 0 =========================================== Hits ? 70105 Misses ? 12805 Partials ? 5193
Hi @b41sh Unfortunately a corner case is triggered in some TiDB internal tests:
TiDB in this PR:
TiDB before this PR:
As is shown, there is another compatibility issue about JSON(possibly related to #9996) in TiDB. But it was hidden in previous tests because although the result was WRONG, no error was raised.
I think we may: comment related test cases to make this PR merged firstly, or wait until the binary(or say, base64) related issue is solved.