Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design: update 2019-04-11-indexmerge.md with some edits #10530

Merged
merged 6 commits into from May 24, 2019

Conversation

@dcalvin
Copy link
Member

dcalvin commented May 19, 2019

What problem does this PR solve?

Some edits on the language @eurekaka Please make sure the edits don't alter any technical meaning as intended.

Some edits on the language
@dcalvin dcalvin requested a review from eurekaka May 19, 2019
@dcalvin dcalvin changed the title Update 2019-04-11-indexmerge.md design: update 2019-04-11-indexmerge.md with some edits May 19, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented May 19, 2019

Codecov Report

Merging #10530 into master will increase coverage by 0.0258%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #10530        +/-   ##
================================================
+ Coverage   77.2784%   77.3043%   +0.0258%     
================================================
  Files           413        412         -1     
  Lines         86966      86629       -337     
================================================
- Hits          67206      66968       -238     
+ Misses        14593      14511        -82     
+ Partials       5167       5150        -17
@codecov

This comment has been minimized.

Copy link

codecov bot commented May 19, 2019

Codecov Report

Merging #10530 into master will decrease coverage by 0.0034%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #10530        +/-   ##
================================================
- Coverage   77.3846%   77.3812%   -0.0035%     
================================================
  Files           413        413                
  Lines         87476      87476                
================================================
- Hits          67693      67690         -3     
- Misses        14577      14580         +3     
  Partials       5206       5206
@zhouqiang-cl

This comment has been minimized.

Copy link
Member

zhouqiang-cl commented May 19, 2019

/run-all-tests

Copy link
Contributor

eurekaka left a comment

LGTM

docs/design/2019-04-11-indexmerge.md Outdated Show resolved Hide resolved
docs/design/2019-04-11-indexmerge.md Outdated Show resolved Hide resolved
docs/design/2019-04-11-indexmerge.md Outdated Show resolved Hide resolved
docs/design/2019-04-11-indexmerge.md Outdated Show resolved Hide resolved
Co-Authored-By: Zhang Jian <zjsariel@gmail.com>
@dcalvin

This comment has been minimized.

Copy link
Member Author

dcalvin commented May 23, 2019

@zz-jason PTAL. Thanks.

@zhouqiang-cl

This comment has been minimized.

Copy link
Member

zhouqiang-cl commented May 23, 2019

/rebuild

Copy link
Member

zz-jason left a comment

LGTM

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels May 24, 2019
@zz-jason zz-jason merged commit cc74145 into pingcap:master May 24, 2019
8 checks passed
8 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing b83e333...78c6ec9
Details
codecov/project 77.3812% (-0.0035%) compared to b83e333
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.